CI/CD checks

IDE configs

Software design ANTI pattern

Domain modeling made functional

Red Book

Blue Book by Eric Evans

Working effectively with legacy code

Dev env

Configuration vs Hard coded values

(8)UI interaction checks (error message)

Project documentation impact

(7) Are not covered (why ?)

Regulatory requirements

Security

(7)Documentation : tests (automated)

(6)Happy / Exceptional cases

Understand new code

YAGNI / KISS principle : Extreme Programming

Code reuse / refactoring opportunity

(2)DDD

(2)SOLID

Fit with overall architecture

Automated vs Human reviews

Reduce cognitive load

Test coverage

Naming

Style

Formatting

(15) Dependabot

(14) Big-O Cheat Sheet and Sort

(13) Optional

(12) TwoHardThings

(11) Concurrency is not Parallelism by Rob Pike

(10) Brendan Gregg Flamegraphs' / Humans are terrible at guessing about performance

(9) Type Driven Development > Functional Programming

(8)Does this change require QA sync (Tres Amigos) ?

(7)How about Property Based Testing ?

(6)Exception vs Error : Golang procedural > Code complexity > Generics > Functional Programming (vavr java, fsharp, rust, scala, ...)

(5)How about Code Complexity metrics ?

(4)Extreme Programming

(3)Software design pattern

(2)SOLID/DDD, reduce cognitive load, ... > Functional Programming

(1) How about reviewing a full codebase ?

Share

Reflection / Timeoouts

Compare config performance when needed

Use Default config first

End to End (QA, ...)

Benchmark

Types

(9)Cardinality (null, 1, N)

Have you though about...?

Functionality

Readability / Maintainability

Design

Personal references

Culture

(12)Caching issues

Locks

Race conditions

Wrong Data structure

Upsource

(15)Reduce dependencies

Automation

(14)Optional

Choose the right one

Pitfalls (Stream api)

(11)Parallelism

Code smells

Configuration Pools

Resource Management (connections, streams, ...)

Boundings / Life cycle of data (add / remove from list)

Memory Leaks

Locks

Network cost : (10)Batch and number of calls

Not all code requires performance : Performance vs Readability

(10)Performance fix

Fit actual implementation vs expected performance

Requirements

Pair Programming : Reviewers can write tests too

Performance Tests

Security

Type/Level

Keep intention with a test

Limitations (accidental vs intentional)

Edge cases

Granularity (unit > ... > end to end)

Test is code to maintain, it should follow the same code rules

Meaning of test ?

Catch uncovered new blocks

Focus on important code (core)

What to look for ?

Sources

Developer Advocate @ JetBrains

Author

Java Champion

Sum up

Correctness

Tooling

Security

(2)SOLID Principles

(13)Data Structures

Performance

Tests

Introduction (1)

About this Book

The author : Trisha Gee

What to look for in a code review